Wireshark-commits: [Wireshark-commits] master 90c4cbe: If it's used by dissectors, it belongs in to
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=90c4cbef192b299b424d03a3de1727bf2dd0af4a
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
90c4cbe by Guy Harris (guy@xxxxxxxxxxxx):
If it's used by dissectors, it belongs in to_str.h, not to_str-int.h.
Assuming *any* of the routines that generate printable strings should be
thought of as "for internal use by libwireshark routines only, not by
dissectors", the ones that *are* used by dissectors obviously shouldn't
be. The ability for dissectors to register address types certainly
expands the list of routines they would use.
Move everything used by dissectors from to_str-int.h into to_str.h, and
have dissectors not include to_str-int.h.
(Perhaps we should just get rid of to_str-int.h altogether.)
Change-Id: I3c583351f038233c9bcd8f9216188f82630267fa
Reviewed-on: https://code.wireshark.org/review/11149
Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
Actions performed:
from 7fc8804 RLC LTE graph: allow switching between zoom and drag, and place limits on each
adds 90c4cbe If it's used by dissectors, it belongs in to_str.h, not to_str-int.h.
Summary of changes:
epan/dissectors/packet-arcnet.c | 2 +-
epan/dissectors/packet-atalk.c | 1 -
epan/dissectors/packet-devicenet.c | 2 +-
epan/dissectors/packet-ieee80211.c | 2 +-
epan/dissectors/packet-ieee802154.c | 2 +-
epan/dissectors/packet-j1939.c | 2 +-
epan/dissectors/packet-mstp.c | 2 +-
epan/dissectors/packet-sna.c | 2 +-
epan/to_str-int.h | 44 ----------------------------------
epan/to_str.h | 45 +++++++++++++++++++++++++++++++++--
10 files changed, 50 insertions(+), 54 deletions(-)
