Wireshark-commits: [Wireshark-commits] master 969c307: Qt: various fixes to UAT dialog
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 16 Oct 2015 06:22:50 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=969c307820f03a98f3fe1980e0903cb8e2b6e6b0
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

969c307 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    Qt: various fixes to UAT dialog
    
    - call set callback even when no check callback is available
    - convert an ascii string containing hex to an hex string for PT_TXTMOD_HEXBYTES entries
    - move update_cb call to the end of stringPrefEditingFinished() (to avoid calling it each time a character is typed in the edit line)
    - when a new row is created, ensure that UAT record is configured with the default enum value selected by the GUI
    
    Bug: 11396
    Change-Id: I9d1094629b4a014fed1704b35cd795cd7f2f136a
    Reviewed-on: https://code.wireshark.org/review/11032
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  40fe748   TCP(.h): fix comma at end of enumerator list [-Wpedantic]
    adds  969c307   Qt: various fixes to UAT dialog


Summary of changes:
 ui/qt/uat_dialog.cpp |   94 +++++++++++++++++++++++++++++++++++---------------
 ui/qt/uat_dialog.h   |    1 +
 ui/qt/uat_dialog.ui  |    7 ++++
 3 files changed, 74 insertions(+), 28 deletions(-)