Wireshark · Wireshark-commits: [Wireshark-commits] master-2.0 3291f7a: Revert "Another message from Clang for unknown -f and -m fla

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3291f7aef1a54b2e2710ccc3a1797e1189c68359
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

3291f7a by Peter Wu (peter@xxxxxxxxxxxxx):

    Revert "Another message from Clang for unknown -f and -m flags."
    
    This reverts commit 5e5e2019ee09fb0901f35948f570baff8a884adb.
    
    This change was proposed in https://cmake.org/Bug/view.php?id=13194 to
    catch some Clang warnings concerning invalid -m flags, but it is causing
    legitimate breakage when setting CMAKE_C_FLAGS=-gsplit-dwarf.
    CMakeFiles/CMakeError.log shows:
    
        /usr/bin/clang  -gsplit-dwarf -DC__W_VALID    CMakeFiles/cmTC_04cc8.dir/src.c.o  -o cmTC_04cc8 -rdynamic
        clang-3.7: warning: argument unused during compilation: '-gsplit-dwarf'
    
    With the additional regex, basic checks (like -Wall but also -fPIE) are
    incorrectly reported as unsupported. Follow upstreams action here and
    remove it, it is still not present as of CMake 3.3.2.
    
    Change-Id: I8a1e97b16c2bb929436cca669fdb42f33612c490
    Reviewed-on: https://code.wireshark.org/review/10880
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Jörg Mayer <jmayer@xxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit 14085e043a2b7f3b53d1c57fe2a06beb691c95dc)
    Reviewed-on: https://code.wireshark.org/review/11039
    

Actions performed:

    from  eea2dfa   cmake: always enable -Qunused-arguments for clang
    adds  3291f7a   Revert "Another message from Clang for unknown -f and -m flags."


Summary of changes:
 cmake/modules/CheckCCompilerFlag.cmake |    1 -
 1 file changed, 1 deletion(-)