Wireshark-commits: [Wireshark-commits] master 95804d9: cmake: avoid adding -fPIE to libraries (fixe
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 14 Oct 2015 22:49:58 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=95804d94e8cc07c6361287ff7ade0600f11b2078
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

95804d9 by Peter Wu (peter@xxxxxxxxxxxxx):

    cmake: avoid adding -fPIE to libraries (fixes gcc 4.7)
    
    On Debian Wheezy, the cmake build would fail with:
    
        /usr/bin/ld: CMakeFiles/wsutil.dir/privileges.c.o: relocation
        R_X86_64_PC32 against symbol `started_with_special_privs' can not be
        used when making a shared object; recompile with -fPIC
    
    Issue was introduced with v1.99.10rc0-222-g3fb1d68 ("cmake: Enable PIE
    when it is available by default").
    
    Bug: 11587
    Change-Id: I62eec8d1db020128eeeb77b38e3316abf71e6e6a
    Reviewed-on: https://code.wireshark.org/review/10916
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Balint Reczey <balint@xxxxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  14085e0   Revert "Another message from Clang for unknown -f and -m flags."
    adds  95804d9   cmake: avoid adding -fPIE to libraries (fixes gcc 4.7)


Summary of changes:
 CMakeLists.txt |    9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)