Wireshark-commits: [Wireshark-commits] master e059e45: cmake: always enable -Qunused-arguments for
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 14 Oct 2015 16:53:28 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e059e4588636bbe88b3706b962469a2003550b51
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e059e45 by Peter Wu (peter@xxxxxxxxxxxxx):

    cmake: always enable -Qunused-arguments for clang
    
    "argument unused during compilation" warnings suggest that some options
    do not make sense (such as passing the -gsplit-dwarf option to the
    linking command while it is only valid during compilation).
    
    For now we do not care about these warnings, the option is accepted by
    clang and whether it used in a particular step or not is uninteresting.
    
    Change-Id: I3b6efa0dccd33c7f351c5938a29adef64ac1706d
    Reviewed-on: https://code.wireshark.org/review/10893
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  5179a91   Add a URL for the Qt retina markup bug.
    adds  e059e45   cmake: always enable -Qunused-arguments for clang


Summary of changes:
 CMakeLists.txt |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)