Wireshark-commits: [Wireshark-commits] master-2.0 e4caf13: cmake: link against dl, fixes linking wi
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 14 Oct 2015 16:46:33 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e4caf132d7b2da30d0d88f50c7cdc4d3603202e0
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

e4caf13 by Peter Wu (peter@xxxxxxxxxxxxx):

    cmake: link against dl, fixes linking with gold
    
    wsutil/filesystem.c uses dladdr (when available), but does not declare a
    dependency on it. Adding it fixes a CMAKE_C(XX)_FLAGS=-fuse-ld=gold
    build failure:
    
        run/libwsutil.so.0.0.0: error: undefined reference to 'dladdr'
    
    This change is somehow not necessary for autotools, just for cmake.
    
    Change-Id: I642a7d85f9c33541831262f930e73d1f47c58b60
    Reviewed-on: https://code.wireshark.org/review/10906
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Jörg Mayer <jmayer@xxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit e6a071db059b1b84a3570292b3f49844c8108627)
    Reviewed-on: https://code.wireshark.org/review/11035
    

Actions performed:

    from  ad6acca   TCP: only store up to 1000 unacked segments (in each direction).
    adds  e4caf13   cmake: link against dl, fixes linking with gold


Summary of changes:
 wsutil/CMakeLists.txt |    1 +
 1 file changed, 1 insertion(+)