Wireshark-commits: [Wireshark-commits] master-1.12 58ef8e0: TCP: only store up to 1000 unacked segm
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 14 Oct 2015 13:44:15 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=58ef8e0be53353d87b91afad1c37120822c2c69e
Submitter: Jeff Morriss (jeff.morriss.ws@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

58ef8e0 by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    TCP: only store up to 1000 unacked segments (in each direction).
    
    If we're seeing only one side of a conversation (we're not seeing any ACKs)
    then things get really, really slow as the number of unacked segments grows.
    
    1000 is, of course, an arbitrary limit.
    
    Bug: 11589
    Change-Id: I42652965b736da50122c722e6ac386c4d481e57f
    Reviewed-on: https://code.wireshark.org/review/10971
    Petri-Dish: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 065c4646a631690896c9b45cadc4cc2d012255d8)
    Reviewed-on: https://code.wireshark.org/review/11013
    Reviewed-by: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    

Actions performed:

    from  8c824ba   Updates for 1.12.8.
    adds  58ef8e0   TCP: only store up to 1000 unacked segments (in each direction).


Summary of changes:
 epan/dissectors/packet-tcp.c |    8 ++++++--
 epan/dissectors/packet-tcp.h |    4 +++-
 2 files changed, 9 insertions(+), 3 deletions(-)