Wireshark-commits: [Wireshark-commits] master 01f82ee: cmake: fix kerberos library lookup, support
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 13 Oct 2015 07:36:38 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=01f82ee84cc849aa7c2f344d2067f0d81715490d
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

01f82ee by Peter Wu (peter@xxxxxxxxxxxxx):

    cmake: fix kerberos library lookup, support Heimdal
    
    A build with the gold linker broke with:
    
        run/libwireshark.so.0.0.0: error: undefined reference to 'krb5_c_decrypt'
    
    Fix this my restructuring the FindKERBEROS module to use the libraries
    found by pkg-config.
    
    While at it, check for MIT and Heimdal instead of assuming MIT. Remove
    HAVE_KEYTYPE_ARCFOUR_56 as this macro is not used.
    
    Change-Id: Iab23d79bc3f25e9c0fd7203b6f050f875fb4a2b5
    Reviewed-on: https://code.wireshark.org/review/10907
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Jörg Mayer <jmayer@xxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  e6a071d   cmake: link against dl, fixes linking with gold
    adds  01f82ee   cmake: fix kerberos library lookup, support Heimdal


Summary of changes:
 CMakeLists.txt                   |    3 --
 cmake/modules/FindKERBEROS.cmake |   96 ++++++++++++++++++++++----------------
 cmakeconfig.h.in                 |    3 --
 3 files changed, 56 insertions(+), 46 deletions(-)