Wireshark-commits: [Wireshark-commits] master a386fc9: ssl-utils: Fix parsing pre-master-secrets in
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 13 Oct 2015 07:34:35 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a386fc99ac72b4cdb88cb3d26fd19d6251391b96
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a386fc9 by Gergely Nagy (ngg@xxxxxx):

    ssl-utils: Fix parsing pre-master-secrets in keylog-file
    
    With "PMS_CLIENT_RANDOM xxxx yyyy" lines, only 32 byte long pre-master
    secrets could be entered, but they are 48 byte long for RSA and can be
    of any length for DHE cipher suites.
    
    When a line had the "RSA xxxx yyyy" format then yyyy was previously
    parsed with the <master_secret> regex group but it contains
    the pre-master secret, so now it is parsed with the <pms> group.
    This didn't cause a functional issue for RSA, but it couldn't be used
    where the pre-master secret isn't 48 byte long.
    
    After this change the regex will accept everything that was previously
    working.
    
    Change-Id: I71f43f3e9977a5e98758f387ad69893e8be0e27a
    Reviewed-on: https://code.wireshark.org/review/10923
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  f6d61eb   qt: add missing initializers (CID 1325722)
    adds  a386fc9   ssl-utils: Fix parsing pre-master-secrets in keylog-file


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |   16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)