Wireshark-commits: [Wireshark-commits] master-2.0 f8e044b: Support in 6lowpan for RFC4944 address g
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 10 Oct 2015 01:29:27 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f8e044b74d4fe82ad8ba94c765522d4f51679097
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

f8e044b by Pedro Jose Marron (pjmarron@xxxxxxxxxxxx):

    Support in 6lowpan for RFC4944 address generation
    
    For the conversion of a 16-bit short address in 6lowpan to an IID, there
    are several RFCs that produce different results. RFC 4944 section 6
    specifies that the conversion uses the given PAN ID and the 16-bit short
    address. RFC 6282, on the other hand, specifies thta the conversion only
    uses the 16-bit short address and no longer uses the PAN ID.
    
    The current version of the 6lowpan dissector supports only the newer RFC
    6282, but there are protocols out there that assume that the address
    conversion still abides to RFC 4944.
    
    In order to support these protocols and following the discussion from
    
    https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8970
    
    this patch introduces a boolean preference in the 6lowpan dissector that
    indicates whether or not the older RFC 4944 should be used for address
    conversion. By default, it is set to FALSE, thus leaving the behavior of
    the dissector unchanged.
    
    Besides the boolean preference, another helper function
    lowpan_addr16_with_panid_to_ifcid has been written that implements the
    expected behavior from RFC 4944 using the same hint mechanism already in
    place in the dissector for the support of RFC 6282.
    
    Bug: 8970
    Change-Id: I8d202c69a225d7b1212080a174e0111e5203553c
    Reviewed-on: https://code.wireshark.org/review/10902
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    (cherry picked from commit 911da8b9d5e2215e7851e0874f0cdffac5961c73)
    Reviewed-on: https://code.wireshark.org/review/10920
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  bf594af   Add WS_DLL_PUBLIC for Address Type Registration
    adds  f8e044b   Support in 6lowpan for RFC4944 address generation


Summary of changes:
 epan/dissectors/packet-6lowpan.c |   86 +++++++++++++++++++++++++++++++++++---
 1 file changed, 81 insertions(+), 5 deletions(-)