Wireshark-commits: [Wireshark-commits] master 6d7b295: Allow use of variadic macros
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 5 Oct 2015 07:57:24 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6d7b29592aa9cac3f10823ea8f33b18893707e83
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

6d7b295 by Peter Wu (peter@xxxxxxxxxxxxx):

    Allow use of variadic macros
    
    Remove variadic macros restriction (c99, c++11 feature) from
    README.developer. GCC, Clang, MSVC 2005 all support it.
    
    Enable -Wno-variadic-macros in configure.ac and CMakeLists.txt when
    -Wpedantic is enabled (which would enable -Wvariadic-macros).
    
    For all files matching 'define\s*\w+[0-9]\(', replace "FOO[0-9]" by
    "FOO" and adjust the macro definition accordingly. The nbap dissector
    was regenerated after adjusting its template and .cnf file. The
    generated code is the same since all files disabled the debug macros.
    
    Discussed at:
    https://www.wireshark.org/lists/wireshark-dev/201209/msg00142.html
    https://www.wireshark.org/lists/wireshark-dev/201510/msg00012.html
    
    Change-Id: I3b2e22487db817cbbaac774a592669a4f44314b2
    Reviewed-on: https://code.wireshark.org/review/10781
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  5b1d142   Fix warnings introduced by "Qt: Initial RTP playback"
    adds  6d7b295   Allow use of variadic macros


Summary of changes:
 CMakeLists.txt                   |    1 +
 asn1/nbap/nbap.cnf               |   48 +++---
 asn1/nbap/packet-nbap-template.c |   12 +-
 configure.ac                     |    1 +
 doc/README.developer             |   17 --
 epan/dissectors/packet-icep.c    |   66 ++++----
 epan/dissectors/packet-nbap.c    |   74 ++++-----
 epan/dissectors/packet-netflow.c |   18 +--
 tshark.c                         |   68 ++++----
 wiretap/ipfix.c                  |   34 ++--
 wiretap/merge.c                  |   62 ++++---
 wiretap/pcapng.c                 |  328 +++++++++++++++++++-------------------
 12 files changed, 333 insertions(+), 396 deletions(-)