Wireshark-commits: [Wireshark-commits] master 2496aed: Qt: Don't update the recent list while captu
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 5 Oct 2015 02:58:35 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2496aed28eecc3466f8de49f67393b0798c664fb
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2496aed by Gerald Combs (gerald@xxxxxxxx):

    Qt: Don't update the recent list while capturing.
    
    If a recent file is on a network share we'll create traffic which can
    show up in the capture.
    
    This doesn't fix the issue entirely, e.g. if you're capturing in one
    instance of Wireshark and have another one open. The proper fix in that
    case is to switch to QFileSystemWatcher as described at the top of
    ::WiresharkApplication.
    
    Ping-Bug: 11546
    Change-Id: If21f1bb213fe1d862c09b1b2edd78c8baf983461
    Reviewed-on: https://code.wireshark.org/review/10774
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    

Actions performed:

    from  05e0375   Remove tr() for setObjectName
    adds  2496aed   Qt: Don't update the recent list while capturing.


Summary of changes:
 ui/qt/main_window.cpp           |    9 +++++++++
 ui/qt/wireshark_application.cpp |    6 +++++-
 ui/qt/wireshark_application.h   |    3 +++
 3 files changed, 17 insertions(+), 1 deletion(-)