Wireshark-commits: [Wireshark-commits] master a013823: Add the conversation hash tables internals d
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 1 Oct 2015 17:25:35 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a013823934b437c43960959ee725858e1b75ed15
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a013823 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Add the conversation hash tables internals dialog.
    
    The GTK+ version dumps "new" and "old" hash values. It looks like
    neither are valid since the code in conversation.c and
    conversation_hashtables_dlg.c have diverged.
    
    For now just dump the addresses and ports for each hash table in the Qt
    UI.
    
    Change-Id: I832522dff06da769bd4ad3ead3d541206f283a90
    Reviewed-on: https://code.wireshark.org/review/10713
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  6193e3c   Add dissection of 3GPP AVP 655 refactor to use proto_tree_add_bitmask_with_flags() in some cases.
    adds  a013823   Add the conversation hash tables internals dialog.


Summary of changes:
 ui/qt/CMakeLists.txt                               |    3 +
 ui/qt/Makefile.am                                  |    2 +
 ui/qt/Makefile.common                              |    4 +
 ui/qt/Wireshark.pro                                |    3 +
 ui/qt/conversation_hash_tables_dialog.cpp          |  101 ++++++++++++++++++++
 ..._dialog.h => conversation_hash_tables_dialog.h} |   22 ++---
 ...ialog.ui => conversation_hash_tables_dialog.ui} |   16 ++--
 ui/qt/main_window.h                                |    1 +
 ui/qt/main_window.ui                               |    9 ++
 ui/qt/main_window_slots.cpp                        |    7 ++
 10 files changed, 146 insertions(+), 22 deletions(-)
 create mode 100644 ui/qt/conversation_hash_tables_dialog.cpp
 copy ui/qt/{export_pdu_dialog.h => conversation_hash_tables_dialog.h} (69%)
 copy ui/qt/{mtp3_summary_dialog.ui => conversation_hash_tables_dialog.ui} (78%)