Wireshark · Wireshark-commits: [Wireshark-commits] master ea2fcb5: Refactor NCP Python data so that INFO column can be generated on

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ea2fcb552c5462f9be1fea482350edbf7f6c1fc9
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ea2fcb5 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Refactor NCP Python data so that INFO column can be generated on the fly (TAKE 2)
    
    The "old" method of populating the INFO column was to dissect all fields of a function/subfunction, then do a search in the tree to find the hf_ values of interest to then format into something for the INFO column.  This is very expensive and requires "low level" APIs (for tree manipulation) which really shouldn't be used in a dissector.
    
    The "new" method populates the INFO column at the same time a field is parsed, so nothing has to be revisited (and allows for more fields to be displayed on some malformed packets).
    
    There are still expert infos (and possibly column APIs) under if (tree)s, but I'm not sure how FAKE_TREE_IS_VISIBLE factors into that.  Removing the FAKE_TREE_IS_VISIBLE seems to negatively affect dissection.
    
    Change-Id: Ie487e851c2f6558dd12f0c7010757b4a5f36226b
    Reviewed-on: https://code.wireshark.org/review/10631
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  40a43bd   UI QT: fix unused variable 'show_delay_' error
    adds  ea2fcb5   Refactor NCP Python data so that INFO column can be generated on the fly (TAKE 2)


Summary of changes:
 epan/dissectors/packet-ncp-int.h   |   15 +-
 epan/dissectors/packet-ncp2222.inc |  463 +++++++----------
 tools/ncp2222.py                   |  960 +++++++++++++++++++-----------------
 3 files changed, 679 insertions(+), 759 deletions(-)