Wireshark-commits: [Wireshark-commits] lts-1.12.1 1c7952b: WaveAgent - Use tvb_get_guint8 instead o
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 22 Sep 2015 20:44:00 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1c7952b62352c74e48dde9ce506b7163a80dbbbf
Submitter: Balint Reczey (balint@xxxxxxxxxxxxxxx)
Changed: branch: lts-1.12.1
Repository: wireshark

Commits:

1c7952b by Michael Mann (mmann78@xxxxxxxxxxxx):

    WaveAgent - Use tvb_get_guint8 instead of tvb_get_ptr to walk a packet and protect against a really big tag value
    
    Ping-Bug: 11358
    Change-Id: I9ecb5fe6bcd7f25c763d968bf56fb2d9bce2180c
    Reviewed-on: https://code.wireshark.org/review/9639
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit 5523726e6960fe9d7e301376fd7a94599f65fd42)
    Reviewed-on: https://code.wireshark.org/review/9653
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 1c1733e4be25c1e125e02f9eae2c7dc2e0206bf4)
    Reviewed-on: https://code.wireshark.org/review/10586
    Reviewed-by: Balint Reczey <balint@xxxxxxxxxxxxxxx>
    

Actions performed:

    from  725310e   GSM RLC/MAC: fix an infinite loop when analyzing (E)GPRS header
    adds  1c7952b   WaveAgent - Use tvb_get_guint8 instead of tvb_get_ptr to walk a packet and protect against a really big tag value


Summary of changes:
 epan/dissectors/packet-waveagent.c |   13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)