Wireshark · Wireshark-commits: [Wireshark-commits] master 3b09a9e: nfs: Register CB program statically and not whilst parsing it

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3b09a9e4570a876faec23ba7a1d8be8ac981f92a
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3b09a9e by Tom Haynes (loghyr@xxxxxxxxxxxxxxx):

    nfs: Register CB program statically and not whilst parsing it
    
    The existing code parsed the callback program number from
    a packet and then registered the callback program number.
    But since the RPC dissector checks for valid and known
    program numbers, it never parses it out.
    
    Anyway, NFS4_CALLBACK is a well known number - use it!
    
    Change-Id: Ia812359102bf6620e3b83109eb918032155cd8d3
    Signed-off-by: Tom Haynes <loghyr@xxxxxxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/10558
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  741ee8c   Arguably, some sort of assert belongs there.
    adds  3b09a9e   nfs: Register CB program statically and not whilst parsing it


Summary of changes:
 epan/dissectors/packet-nfs.c |   20 +++++---------------
 epan/dissectors/packet-nfs.h |    1 +
 2 files changed, 6 insertions(+), 15 deletions(-)