Wireshark-commits: [Wireshark-commits] lts-1.12.1 870b889: Fix ptvcursor_add() so it can dissect th
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 20 Sep 2015 18:28:05 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=870b8892d40ef89946be6eff6d078eb750d4944d
Submitter: Balint Reczey (balint@xxxxxxxxxxxxxxx)
Changed: branch: lts-1.12.1
Repository: wireshark

Commits:

870b889 by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    Fix ptvcursor_add() so it can dissect the last bytes in a TVB again.
    
    ptvc->offset has already been incremented by the item length so don't use it as
    the offset to test_length(); we need to use the original offset.
    
    Problem introduced by Idfd258c734e7a946300b2564bebf6e4cb374c8d1 .
    
    Change-Id: I0421539bde6e8eb7b5aa3e22dbb0ca8098e88d6f
    Reviewed-on: https://code.wireshark.org/review/9783
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 9831d16cb06a08b4de1857ba35935edd0a8996af)
    Reviewed-on: https://code.wireshark.org/review/10589
    Reviewed-by: Balint Reczey <balint@xxxxxxxxxxxxxxx>
    

Actions performed:

    from  012daad   Add test_length to ptvcursor_add so it can do some bounds checking.
    adds  870b889   Fix ptvcursor_add() so it can dissect the last bytes in a TVB again.


Summary of changes:
 epan/proto.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)