Wireshark-commits: [Wireshark-commits] master 8626bb4: Make CSN.1 dissectors more filterable.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 20 Sep 2015 18:08:11 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8626bb4cbb4d9926f7b56663585d9ef66252f93f
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8626bb4 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Make CSN.1 dissectors more filterable.
    
    The intent here is to remove proto_tree_add_text from packet-csn1.c, but the macros setup means A LOT more hf fields needs to be created.
    
    Many of those new hf fields were created with a perl script
    
    Bug: 11504
    Change-Id: If12c7677185f18a7f684fd3746397be92b56b36d
    Reviewed-on: https://code.wireshark.org/review/10391
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  4ec8a06   [Automatic update for 2015-09-20]
    adds  8626bb4   Make CSN.1 dissectors more filterable.


Summary of changes:
 epan/dissectors/packet-csn1.c       |  366 ++-
 epan/dissectors/packet-csn1.h       |  154 +-
 epan/dissectors/packet-gmr1_bcch.c  |  364 ++-
 epan/dissectors/packet-gsm_rlcmac.c | 5558 ++++++++++++++++++++++++++++++-----
 4 files changed, 5372 insertions(+), 1070 deletions(-)