Wireshark-commits: [Wireshark-commits] master 9162177: Make IPv4/IPv6 DiffServ fields uniform
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 18 Sep 2015 04:12:52 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9162177db968f1310d867c32d2920298302f01b5
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9162177 by João Valverde (joao.valverde@xxxxxxxxxxxxxxxxxx):

    Make IPv4/IPv6 DiffServ fields uniform
    
    Replace DSCP/ECT/CE with DSCP/ECN for IPv6.
    
    Introduce short descriptions for DSCP/ECN values.
    
    Formating changes:
    
     - Make IPv4 and IPv6 as similar as possible.
    
     - Display short abbreviations only for "Differentiated Services Field".
    
     - Display DiffServ field as hex for IPv4.
    
     - Elide leading zeros from hex representation from DiffServ field for IPv6.
    
     - Display DSCP/ECN as decimal in subtree (same as "IP DSCP" column format).
    
    Change-Id: Ia69d11dc9c1d752eb2e269314287c885506b5353
    Reviewed-on: https://code.wireshark.org/review/10360
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  69d2d58   pkcs1: remove unused RSAPrivateKey definition
    adds  9162177   Make IPv4/IPv6 DiffServ fields uniform


Summary of changes:
 epan/dissectors/packet-ip.c   |   74 ++++++++++++++++++++++-----------
 epan/dissectors/packet-ip.h   |   15 ++++++-
 epan/dissectors/packet-ipv6.c |   90 +++++++++++++----------------------------
 3 files changed, 90 insertions(+), 89 deletions(-)