Wireshark-commits: [Wireshark-commits] master ae4d99b: Packet list speedups.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 17 Sep 2015 19:37:55 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ae4d99b670c97e418e9d14417827326d912e76fb
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ae4d99b by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Packet list speedups.
    
    beginInsertRows + endInsertRows is expensive. Instead of calling them
    each time we add a packet to the list, queue up a list of visible packets
    and flush it during the next UI update.
    
    Assume that none of our column data has newlines. Enable
    uniformRowHeights and only disable it when we need to. Note that this
    requires further work.
    
    Ping-Bug: 11515
    Ping-Bug: 10924
    
    Change-Id: Ifbdd2964b174247a4745d4889ebda5bf3b886ba4
    Reviewed-on: https://code.wireshark.org/review/10553
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  dabdc30   IAX2: Initialize a variable.
    adds  ae4d99b   Packet list speedups.


Summary of changes:
 ui/qt/main_window_slots.cpp |    2 ++
 ui/qt/packet_list.cpp       |   17 ++++++++++++
 ui/qt/packet_list.h         |    2 ++
 ui/qt/packet_list_model.cpp |   60 +++++++++++++++++++++++++++++--------------
 ui/qt/packet_list_model.h   |    9 ++++---
 5 files changed, 68 insertions(+), 22 deletions(-)