Wireshark-commits: [Wireshark-commits] master-1.12 d840553: TCAP: support dialogue confirmation
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 14 Sep 2015 21:05:28 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d84055301218fdcd81cd7a2e53ab44440996ddd0
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

d840553 by Luke Mewburn (luke@xxxxxxxxxxx):

    TCAP: support dialogue confirmation
    
    TCAP permits the changing of the originating address on the first
    backwards continue (i.e. the establishment of the dialogue).
    See ITU-T Q.771 (06/97) clause 3.1.2.2.2.2 Confirmation of the dialogue.
    In practice, a BEGIN replied to with an END can also exhibit this behaviour.
    
    For example, a BEGIN from GT A TID TA -> GT B,
    and the reply CONTINUE from GT B2 TID TB -> GT A TID TA.
    To support this, only support a single address hash in
    tcaphash_begin_info_key_t and tcaphash_end_info_key_t.
    The match of the first CONTINUE should find the appropriate
    tcaphash_begin and create the appropriate tcaphash_end entries.
    
    Also fix compile warning with DEBUG_TCAPSRT.
    
    Bug: 10841
    Change-Id: Ibe75e3940e757727357b20be10f9c195c5888fdd
    Reviewed-on: https://code.wireshark.org/review/6446
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit 119416ef2765f290b4cdaaf930438f9b603abd9c)
    Reviewed-on: https://code.wireshark.org/review/9766
    

Actions performed:

    from  563c43e   [Automatic update for 2015-09-13]
    adds  d840553   TCAP: support dialogue confirmation


Summary of changes:
 asn1/tcap/packet-tcap-template.c |  110 +++++++++++++++++++-------------------
 asn1/tcap/packet-tcap-template.h |    6 +--
 epan/dissectors/packet-tcap.c    |  110 +++++++++++++++++++-------------------
 epan/dissectors/packet-tcap.h    |    8 ++-
 4 files changed, 115 insertions(+), 119 deletions(-)