Wireshark-commits: [Wireshark-commits] master 565a953: Don't invalidate the column cache when we fi
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 13 Sep 2015 18:52:25 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=565a953f24a8d9b327fde05549e27a7b0372b0b9
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

565a953 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Don't invalidate the column cache when we filter packets.
    
    Limit PacketListModel::recreateVisibleRows to checking for packets that
    passed the display filter. Remove the call to resetColumns, which
    invalidates the column string cache.
    
    Call PacketListModel::resetColumns from PacketList::columnsChanged.
    Along with invalidating the column string cache, this triggers a widget
    update which means we shouldn't need to call recreateVisibleRows or
    redrawVisiblePackets. Remove them.
    
    Change-Id: Ic25f139e2c2f8cdebb2a868ccda7eb4127a3013c
    Ping-Bug: 11324
    Ping-Bug: 11514
    Reviewed-on: https://code.wireshark.org/review/10491
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  fccfbf2   Stock icon (Qt): Missing break in switch (CID 1323928)
    adds  565a953   Don't invalidate the column cache when we filter packets.


Summary of changes:
 ui/qt/packet_list.cpp       |    4 ++--
 ui/qt/packet_list_model.cpp |    5 +----
 2 files changed, 3 insertions(+), 6 deletions(-)