Wireshark · Wireshark-commits: [Wireshark-commits] master 2931dc1: Try using GStringChunks in PacketListRecord.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2931dc118b6c9090e03480811c38ca582f20f8f3
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2931dc1 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Try using GStringChunks in PacketListRecord.
    
    This saves a fair amount of memory in tests here. Loading a large
    capture file and sorting on a custom column (tcp.window_size) uses 676
    MB before the change and 634 after.
    
    Add notes about possble further improvements:
    
    Roll our own replacement for GStringChunks using wmem_tree.
    
    Have PacketListRecord::columnString return a const char * instead of a
    const QByteArray.
    
    Change-Id: Icb36194f5ad290828d7106ccc3bf494d07d76d08
    Reviewed-on: https://code.wireshark.org/review/10476
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  c088135   Make sure we delete our PacketListRecords.
    adds  2931dc1   Try using GStringChunks in PacketListRecord.


Summary of changes:
 ui/qt/packet_list_model.cpp  |    2 ++
 ui/qt/packet_list_record.cpp |   32 +++++++++++++++++++++++---------
 ui/qt/packet_list_record.h   |    8 +++++++-
 3 files changed, 32 insertions(+), 10 deletions(-)