Wireshark-commits: [Wireshark-commits] master ea8109e: Bug fix of missing "RTP arrow" in the Flow g
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 11 Sep 2015 16:16:11 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ea8109e958eb9e7050eafe3e91fe47091f7f0e4a
Submitter: ronnie sahlberg (ronniesahlberg@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ea8109e by Michal Pazdera (michal.pazdera@xxxxxxxxx):

    Bug fix of missing "RTP arrow" in the Flow graph of VoIP calls.
    
    This commit fixes bug that I have encountred in the Flow graphs of VoIP calls.
    Where the RTP communication is shown only in one direction. This happens
    because the packet-sip.c dissector is unable to find SIP/SDP setup frame from
    the recivers side and sets the setup frame to 0. Now if no frame is found the
    number of current frame is used. I have checked the previous versions and in
    ver 1.8.12 it worked properly (same as after this change).
    
    Note: I am not sure if the 1.8.12 is the last version where this was working
    properly.
    
    Change-Id: Ibb3cf85cbce03f80a2492eeae6cf64acddc439f5
    Reviewed-on: https://code.wireshark.org/review/10440
    Reviewed-by: Tomáš Kukosa <tomas.kukosa@xxxxxxxxx>
    Reviewed-by: ronnie sahlberg <ronniesahlberg@xxxxxxxxx>
    

Actions performed:

    from  12176f4   Export captured packets correctly.
    adds  ea8109e   Bug fix of missing "RTP arrow" in the Flow graph of VoIP calls.


Summary of changes:
 epan/dissectors/packet-sdp.c |   16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)