Wireshark-commits: [Wireshark-commits] master fd342f7: qt: Fix crash when stopping an empty live ca
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 11 Sep 2015 13:22:52 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fd342f7f739e9b13cbbb39804cf5e636883ea777
Submitter: ronnie sahlberg (ronniesahlberg@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

fd342f7 by Peter Wu (peter@xxxxxxxxxxxxx):

    qt: Fix crash when stopping an empty live capture
    
    When the capture process has not yet received any packets (not even the
    libpcap header), Wireshark-Qt would crash because no valid capture file
    was found. Reproducer:
    
        ssh otherhost sleep 10000 | wireshark -k -i -
    
    GTK displays "Waiting for capture input data" in the status bar until
    the capture file format is determined. After this patch, both versions
    will just display an "Interrupted system call" message.
    
    Change-Id: I146f00c0f4fcab04cddcd4f29b56e97b807a9c40
    Reviewed-on: https://code.wireshark.org/review/10388
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: ronnie sahlberg <ronniesahlberg@xxxxxxxxx>
    

Actions performed:

    from  df3fd2d   initial write atomic
    adds  fd342f7   qt: Fix crash when stopping an empty live capture


Summary of changes:
 ui/qt/main_status_bar.cpp |   12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)