Wireshark-commits: [Wireshark-commits] master 91d863c: Qt: Fix use-after-free pattern
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 8 Sep 2015 06:30:36 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=91d863cc1612453d4ed1c7629738d3057ea61373
Submitter: Stig Bj?rlykke (stig@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

91d863c by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Qt: Fix use-after-free pattern
    
    This fixes crashes due to use of deallocated memory in:
    - Export Packet Dissections
    - Merge Capture Files
    - Edit Packet Comment
    
    Change-Id: I3dab8c0735eb5e642d6a4580d20bc3c81cf1345b
    Reviewed-on: https://code.wireshark.org/review/10392
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    

Actions performed:

    from  f25b8c6   Move some stuff into the only code path where it's used.
    adds  91d863c   Qt: Fix use-after-free pattern


Summary of changes:
 ui/qt/export_dissection_dialog.cpp |   10 +++++++---
 ui/qt/import_text_dialog.cpp       |    5 +++--
 ui/qt/main_window.cpp              |   15 +++++++++------
 ui/qt/packet_list.cpp              |    5 ++++-
 4 files changed, 23 insertions(+), 12 deletions(-)