Wireshark-commits: [Wireshark-commits] master 32e785f: The official #define for 32-bit and 64-bit W
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 2 Sep 2015 22:59:17 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=32e785f81320342058bbee95f84095cd55449c09
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

32e785f by Guy Harris (guy@xxxxxxxxxxxx):

    The official #define for 32-bit and 64-bit Windows is _WIN32.
    
    It's _WIN32, with a leading underscore, not WIN32.  See, for example:
    
        https://sourceforge.net/p/predef/wiki/OperatingSystems/
    
    and
    
        https://msdn.microsoft.com/en-us/library/b0084kay.aspx
    
    *Some* environments may also define WIN32, but we shouldn't depend on
    that.
    
    Replace all-caps "WIN32" referring to Windows in comments and other text
    with "Windows" or "Win32".  (The two are pretty much equivalent, these
    days; nobody much cares about Win16, not that we ever ran on it, and
    64-bit Windows is just a 64-bitified Win32.)
    
    Change-Id: Id327bcd4b1e9baa4f27055eff08c2d9e594d6f70
    Reviewed-on: https://code.wireshark.org/review/10367
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  c4538de   UNISTIM: fix dissection of some audio commands
    adds  32e785f   The official #define for 32-bit and 64-bit Windows is _WIN32.


Summary of changes:
 capture_opts.h            |    2 +-
 dumpcap.c                 |    8 ++++----
 epan/prefs.c              |    2 +-
 extcap.c                  |   22 +++++++++++-----------
 ui/gtk/capture_if_dlg.c   |    2 +-
 ui/gtk/tcp_graph.c        |    2 +-
 wsutil/ws_mempbrk_sse42.c |    2 +-
 7 files changed, 20 insertions(+), 20 deletions(-)