Wireshark-commits: [Wireshark-commits] master 87f2bd4: idl2wrs: some code cleanups.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 2 Sep 2015 02:28:39 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=87f2bd45fc5f7ec2ee7b241df54ecca110280cec
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

87f2bd4 by Dario Lombardo (lomato@xxxxxxxxx):

    idl2wrs: some code cleanups.
    
    Code cleanups include:
    - sanity checks for malloc()
    - change forbidden APIs into g_* versions
    - minor indentation fixes
    - add modeline
    - add compilation for cmake and autotools
    
    Bug: 11052
    Change-Id: I825f04d9703448f9165d188be2bdd185fce5ff5d
    Reviewed-on: https://code.wireshark.org/review/10030
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  aa1f556   MSDP: fix will never be executed [-Wunreachable-code]
    adds  87f2bd4   idl2wrs: some code cleanups.


Summary of changes:
 epan/dissectors/Makefile.am           |    6 +-
 epan/dissectors/dcerpc/CMakeLists.txt |   17 +-
 epan/dissectors/dcerpc/Makefile.am    |   23 +-
 epan/dissectors/dcerpc/idl2wrs.c      |  519 +++++++++++++++++++--------------
 4 files changed, 334 insertions(+), 231 deletions(-)