Wireshark · Wireshark-commits: [Wireshark-commits] master-1.12 f02338a: dtls, ssl: Fix invalid free in UAT key parsing

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f02338ab1cde6cdef548e8952a7287d9db2ad62d
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

f02338a by Peter Wu (peter@xxxxxxxxxxxxx):

    dtls,ssl: Fix invalid free in UAT key parsing
    
    uat_esc returns ep_alloc0 memory which is automatically freed before the
    next frame dissection and must not be passed to g_free(). Fixed a crash
    on OS X and an ASAN report.
    
    Note that this problem is not present on master (1.99.x) as it was
    refactored to use g_malloc. On 1.12.x however the required changes would
    be too large so go for this simpler approach where the caller is
    modified.
    
    Bug: 11443
    Change-Id: I51a2421cee07d4567cedd7453aa75b8ce7d0433d
    Reviewed-on: https://code.wireshark.org/review/10329
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  ec275e1   tshark.pod: fix typo
    adds  f02338a   dtls,ssl: Fix invalid free in UAT key parsing


Summary of changes:
 epan/dissectors/packet-dtls.c |    1 -
 epan/dissectors/packet-ssl.c  |    1 -
 2 files changed, 2 deletions(-)