Wireshark-commits: [Wireshark-commits] master 377d215: Convert the MTP3 stats to new "generic stat
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 31 Aug 2015 23:06:16 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=377d215e0fd1022a093fa44b32f396948e70c119
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

377d215 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Convert the MTP3 stats to new "generic stat API".
    
    Convert both the MTP3 statistics and summary. As with the GSM stats this
    is mostly untested.
    
    Change-Id: I7af8d5f21c8161dc95f7f2c710f32364b6f6a431
    Reviewed-on: https://code.wireshark.org/review/10338
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  e9614ad   Windows: update GeoIP library to 1.6.6
    adds  377d215   Convert the MTP3 stats to new "generic stat API".


Summary of changes:
 epan/dissectors/packet-mtp3.c                      |  197 +++++++++
 epan/dissectors/packet-mtp3.h                      |   14 +-
 epan/stat_groups.h                                 |    1 +
 ui/gtk/CMakeLists.txt                              |    1 -
 ui/gtk/Makefile.common                             |    2 -
 ui/gtk/main_menubar.c                              |    3 +-
 ui/gtk/mtp3_stat.c                                 |  461 --------------------
 ui/gtk/mtp3_stat.h                                 |   53 ---
 ui/gtk/mtp3_summary.c                              |  125 +++++-
 ui/gtk/tap_param_dlg.c                             |    1 +
 ui/qt/CMakeLists.txt                               |    3 +
 ui/qt/Makefile.am                                  |    2 +
 ui/qt/Makefile.common                              |    4 +
 ui/qt/Wireshark.pro                                |    3 +
 ui/qt/gsm_map_summary_dialog.cpp                   |    6 +-
 ui/qt/gsm_map_summary_dialog.ui                    |    2 +-
 ui/qt/main_window.cpp                              |   14 +
 ui/qt/main_window.h                                |    1 +
 ui/qt/main_window.ui                               |   33 +-
 ui/qt/main_window_slots.cpp                        |    7 +
 ui/qt/mtp3_summary_dialog.cpp                      |  404 +++++++++++++++++
 ..._map_summary_dialog.h => mtp3_summary_dialog.h} |   19 +-
 ...ap_summary_dialog.ui => mtp3_summary_dialog.ui} |   10 +-
 23 files changed, 814 insertions(+), 552 deletions(-)
 delete mode 100644 ui/gtk/mtp3_stat.c
 delete mode 100644 ui/gtk/mtp3_stat.h
 create mode 100644 ui/qt/mtp3_summary_dialog.cpp
 copy ui/qt/{gsm_map_summary_dialog.h => mtp3_summary_dialog.h} (79%)
 copy ui/qt/{gsm_map_summary_dialog.ui => mtp3_summary_dialog.ui} (87%)