Wireshark-commits: [Wireshark-commits] master 8ddd480: pcapng: do not byte-swap NRB IPv4 address
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 29 Aug 2015 15:15:31 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8ddd480eaa4c757edf63a66f068fdf7c64a143b0
Submitter: Hadriel Kaplan (hadrielk@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8ddd480 by Hadriel Kaplan (hadrielk@xxxxxxxxx):

    pcapng: do not byte-swap NRB IPv4 address
    
    Per the spec, it's always encoded in network order (4 separate bytes), and
    thus should not be swapped on read.
    
    Bug: 11484
    Change-Id: I6a650896b324f42bfd2e05759c84e87ace733372
    Reviewed-on: https://code.wireshark.org/review/10304
    Petri-Dish: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    

Actions performed:

    from  9158176   pcapng: make SPB cap_len the same as packet_len if IDB snaplen is 0
    adds  8ddd480   pcapng: do not byte-swap NRB IPv4 address


Summary of changes:
 wiretap/pcapng.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)