Wireshark-commits: [Wireshark-commits] master e18e400: Fix a GHashTable assertion in DecodeAsDialog
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 29 Aug 2015 01:20:33 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e18e400e6842a3977e26f84cba2cbb3fc6873f8d
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e18e400 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Fix a GHashTable assertion in DecodeAsDialog.
    
    Make sure we don't call g_hash_table_removed from g_hash_table_foreach,
    which generates an assertion error.
    
    Bug: 11426
    Change-Id: I00283c97b0fc63551b901c0fd526b60c0fb80ace
    Reviewed-on: https://code.wireshark.org/review/10296
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  1663224   Block sizes are unsigned 32-bit quantities; don't stuff them into an int.
    adds  e18e400   Fix a GHashTable assertion in DecodeAsDialog.


Summary of changes:
 ui/qt/decode_as_dialog.cpp |   40 +++++++++++++++++++++++++++++++---------
 ui/qt/decode_as_dialog.h   |    4 +++-
 2 files changed, 34 insertions(+), 10 deletions(-)