Wireshark-commits: [Wireshark-commits] master c1c6132: Don't dissect twice from TapParameterDialog.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 28 Aug 2015 21:16:01 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c1c6132c0dfd81a5f8a014d7df71218e2e8c34f7
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c1c6132 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Don't dissect twice from TapParameterDialog.
    
    When the user applies a display filter in TapParameterDialog we're about
    to start tapping. We need to set the display filter in the main window
    but we shouldn't apply it.
    
    Change-Id: I08bed5c7f470f1dbf32817a7d999f09d2c52f168
    Reviewed-on: https://code.wireshark.org/review/10287
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  d767186   Get rid of trailing blanks.
    adds  c1c6132   Don't dissect twice from TapParameterDialog.


Summary of changes:
 ui/qt/main_window_slots.cpp    |    4 ++--
 ui/qt/tap_parameter_dialog.cpp |    4 ++--
 ui/qt/tap_parameter_dialog.h   |    2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)