Wireshark · Wireshark-commits: [Wireshark-commits] master-1.12 f1ca841: Don't check the radio information when testing for an HT Co

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f1ca8418e869ba95af4615ff878160b3694454e5
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

f1ca841 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't check the radio information when testing for an HT Control header.
    
    I now read 8.2.4.1.10 "Order field" in 802.11-2012 as saying that, in
    management and QoS data frames, the Order bit shouldn't be set for
    non-HT, non-VHT frames, so we can just test it for those frame types
    without bothering to check the radio metadata to see if the frame is an
    HT or VHT frame.
    
    This handles cases where the radio metadata isn't complete, e.g. an HT
    frame with a radiotap header but no MCS field.
    
    Handle this for *all* QoS data frames when capturing.
    
    Get rid of the "fixed-length link-layer header" stuff; it's not being
    used.
    
    Fix a case where we're appending text to a tree item without a space
    separating it from the previous text.
    
    Bug: 11351
    Change-Id: Ic25b1efd506644e58646555fbfc3305c45ffa987
    Reviewed-on: https://code.wireshark.org/review/10291
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  f1c7cad   Make bit masks unsigned.
    adds  f1ca841   Don't check the radio information when testing for an HT Control header.


Summary of changes:
 epan/dissectors/packet-ieee80211.c |  406 ++++++++++++++++++------------------
 epan/dissectors/packet-ieee80211.h |    2 -
 epan/dissectors/packet-ppi.c       |   35 +---
 3 files changed, 214 insertions(+), 229 deletions(-)