Wireshark-commits: [Wireshark-commits] master c04d54f: Preparation Host Flows: make ICMP(v6) code a
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 28 Aug 2015 18:54:41 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c04d54fbd49d36213faa555d1141a7ac3196beed
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c04d54f by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    Preparation Host Flows: make ICMP(v6) code and type retrieval more robust
    
    Do not retrieve type and code base on the info column content.
    Instead store type and code in pinfo structure and retrieve them in sequence analysis tap.
    
    Change-Id: I71cd505d7faf713c2372731495d47b45928a41f8
    Reviewed-on: https://code.wireshark.org/review/10280
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Pascal Artho <pascalartho@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  5179406   Update the release notes.
    adds  c04d54f   Preparation Host Flows: make ICMP(v6) code and type retrieval more robust


Summary of changes:
 epan/dissectors/packet-icmp.c   |    8 ++++++-
 epan/dissectors/packet-icmp.h   |    6 ++++++
 epan/dissectors/packet-icmpv6.c |    8 ++++++-
 ui/tap-sequence-analysis.c      |   44 +++++++++++++++++----------------------
 4 files changed, 39 insertions(+), 27 deletions(-)