Wireshark · Wireshark-commits: [Wireshark-commits] master bc4487a: bootp/dhcp: tighten check for Alcatel extensions

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bc4487a6fcd1dfe5c3ef602f6eac4651d2b55642
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

bc4487a by Jeffrey Smith (whydoubt@xxxxxxxxx):

    bootp/dhcp: tighten check for Alcatel extensions
    
    The check for Alcatel extensions in bootp/dhcp packets is very weak,
    resulting in some false positives.  Then when trying to parse the
    suboptions, the result is an error on the packet.
    
    This change eliminates some false positives by adding a test that the
    vendor-specific option contents match the encapsulated format described
    in section 8.4 of RFC2132.
    
    Change-Id: Ie4188ff900426c2d80a5694fbba5c88385625a61
    Reviewed-on: https://code.wireshark.org/review/10267
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  e1c807c   Add missing callback support.
    adds  bc4487a   bootp/dhcp: tighten check for Alcatel extensions


Summary of changes:
 epan/dissectors/packet-bootp.c |   38 ++++++++++++++++++++++++++++++++++++--
 1 file changed, 36 insertions(+), 2 deletions(-)