Wireshark-commits: [Wireshark-commits] master e234ce8: Rework tapping in Qt dialogs.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e234ce8804e6d27656d5db332ea521392be7d25f
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
e234ce8 by Gerald Combs (gerald@xxxxxxxxxxxxx):
Rework tapping in Qt dialogs.
Add cf_cb_file_retap_started and cf_cb_file_retap_finished to file.[ch].
Add their associated signals to CaptureFile.
Add registerTapListener and removeTapListeners to WiresharkDialog, which
collect and automatically remove tap listeners. Add beginRetapPackets
and endRetapPackets, which can be used to wrap critical sections so that
we don't delete ourselves while tapping. Don't cancel tapping on close
in WiresharkDialog.
Use beginRetapPackets and endRetapPackets in WiresharkDialog and
FollowStreamDialog. We will likely need to add them elsewhere.
Update comments.
Change-Id: I1788a6ade0817c31aa3419216df96be5e36b2178
Reviewed-on: https://code.wireshark.org/review/10261
Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
Actions performed:
from f7e9a79 Add per-dialog progress frames.
adds e234ce8 Rework tapping in Qt dialogs.
Summary of changes:
file.c | 4 +
file.h | 2 +
ui/qt/bluetooth_att_server_attributes_dialog.cpp | 32 ++------
ui/qt/bluetooth_devices_dialog.cpp | 32 ++------
ui/qt/capture_file.cpp | 9 ++-
ui/qt/capture_file.h | 2 +
ui/qt/conversation_dialog.cpp | 16 +---
ui/qt/endpoint_dialog.cpp | 15 +---
ui/qt/expert_info_dialog.cpp | 26 +++----
ui/qt/export_object_dialog.cpp | 25 ++-----
ui/qt/follow_stream_dialog.cpp | 27 +++----
ui/qt/response_time_delay_dialog.cpp | 15 ++--
ui/qt/rtp_analysis_dialog.cpp | 5 +-
ui/qt/service_response_time_dialog.cpp | 24 +++---
ui/qt/simple_statistics_dialog.cpp | 21 ++----
ui/qt/stats_tree_dialog.cpp | 23 +++---
ui/qt/tap_parameter_dialog.cpp | 13 +++-
ui/qt/tap_parameter_dialog.h | 1 +
ui/qt/wireshark_dialog.cpp | 85 +++++++++++++++++-----
ui/qt/wireshark_dialog.h | 77 ++++++++++++++++++++
ui/qt/wlan_statistics_dialog.cpp | 21 ++----
21 files changed, 257 insertions(+), 218 deletions(-)
