Wireshark-commits: [Wireshark-commits] master-1.12 d428732: win32: add detection of Npcap to Window
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 25 Aug 2015 17:27:17 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d42873255555f81273c4e6dd0a845abe9fe24962
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

d428732 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    win32: add detection of Npcap to Windows installer
    
    If Npcap is installed without WinPcap API-compatible mode, propose to install WinPcap
    If Npcap is installed with WinPcap API-compatible mode, do not allow to install Winpcap without manually uninstalling Npcap first
    
    Change-Id: I606f8b11c950fd54cf7fdda7f4a1886cc2580d31
    Reviewed-on: https://code.wireshark.org/review/10197
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Yang Luo <hsluoyz@xxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit d5049eaba76055ffc1104536cec59e2163c8d003)
    Reviewed-on: https://code.wireshark.org/review/10255
    

Actions performed:

    from  ce246a6   [GTK] Fix crash in comparestat.c
    adds  d428732   win32: add detection of Npcap to Windows installer


Summary of changes:
 packaging/nsis/uninstall.nsi |   10 ++++++----
 packaging/nsis/wireshark.nsi |   24 +++++++++++++++++++++++-
 2 files changed, 29 insertions(+), 5 deletions(-)