Wireshark-commits: [Wireshark-commits] master 9c331f7: [GTK] Fix crash in comparestat.c
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 22 Aug 2015 14:34:45 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9c331f73b5be7cde6b04b6cb68cf73deb4bdc4ce
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9c331f7 by João Valverde (joao.valverde@xxxxxxxxxxxxxxxxxx):

    [GTK] Fix crash in comparestat.c
    
    Selecting a row in the statistics table causes a Glib assertion failure.
    
    GLib:ERROR:ghash.c:373:g_hash_table_lookup_node: assertion failed: (hash_table->ref_count > 0)
    
    When the comparestat_draw() function is called, the cs->ip_id_set hash table
    is created and then immediately destroyed, but the hash table lookup
    to cs->ip_id_set in new_tree_view_selection_changed() can happen anytime
    the user clicks on a table row.
    
    Bug: 11098
    Change-Id: I6c7a39c947ca11327c3fc3ab0d4caa735798d142
    Reviewed-on: https://code.wireshark.org/review/10096
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  0d61321   Correct logic for finding shadow variables.
    adds  9c331f7   [GTK] Fix crash in comparestat.c


Summary of changes:
 ui/gtk/compare_stat.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)