Wireshark-commits: [Wireshark-commits] master 74177d9: Statistics dialog fixups.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 22 Aug 2015 01:29:13 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=74177d90d32b485adc3fb83c703e712af6e46663
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

74177d9 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Statistics dialog fixups.
    
    Fix the "retap on show" behavior in TapParameterDialog. It was filling
    in the tree when it shouldn't have.
    
    Set the capture stop flag when WiresharkDialog closes.
    
    Change-Id: I5e85f11cab32e8b958deabb58186a855b5fcaa84
    Reviewed-on: https://code.wireshark.org/review/10186
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  a66a95c   Add packet comments to the properties dialog.
    adds  74177d9   Statistics dialog fixups.


Summary of changes:
 ui/qt/multicast_statistics_dialog.cpp |    1 -
 ui/qt/tap_parameter_dialog.cpp        |   18 +++++++++++++-----
 ui/qt/tap_parameter_dialog.h          |    6 +++---
 ui/qt/wireshark_dialog.cpp            |    4 ++++
 4 files changed, 20 insertions(+), 9 deletions(-)