Wireshark-commits: [Wireshark-commits] master 36a74cb: Tap parameter and stats dialog fixups.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=36a74cb13a7ee8e4e0972243d1a6a9ae641adb03
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
36a74cb by Gerald Combs (gerald@xxxxxxxxxxxxx):
Tap parameter and stats dialog fixups.
If we run into an error when trying to register a tap listener, return
instead of tapping packets. This should fix some (but likely not all)
double frees found by Stig. For now close each statistics dialog if we
find an error. Note that we might want to keep them open instead.
Add checks and cleanups to some of the stats table free routines.
Call fillTree once in TapParameterDialog's constructor instead of each
time it's shown. Make fillTree a slot which lets us use a delay timer so
that the dialog is visible when we retap packets.
Change-Id: Id49f2f2a99bc8e5b1d32990024986b3c8b1abe24
Reviewed-on: https://code.wireshark.org/review/10153
Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
Actions performed:
from 37a737f Make sure we can apply deprecated display filters.
adds 36a74cb Tap parameter and stats dialog fixups.
Summary of changes:
epan/rtd_table.c | 2 ++
epan/stats_tree.c | 2 ++
ui/qt/response_time_delay_dialog.cpp | 3 ++-
ui/qt/response_time_delay_dialog.h | 4 +++-
ui/qt/rpc_service_response_time_dialog.h | 2 +-
ui/qt/service_response_time_dialog.cpp | 4 +++-
ui/qt/service_response_time_dialog.h | 2 ++
ui/qt/simple_statistics_dialog.cpp | 3 ++-
ui/qt/simple_statistics_dialog.h | 1 +
ui/qt/stats_tree_dialog.cpp | 5 +++--
ui/qt/stats_tree_dialog.h | 4 +++-
ui/qt/tap_parameter_dialog.cpp | 35 ++++++++++++++++++++----------
ui/qt/tap_parameter_dialog.h | 6 ++---
13 files changed, 51 insertions(+), 22 deletions(-)
