Wireshark-commits: [Wireshark-commits] master 89a8ad6: Preparation Host Flows: Tap Sequence Analysi
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=89a8ad65650695385d54dd0584ff2a67644e6339
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
89a8ad6 by Pascal Artho (pascalartho@xxxxxxxxx):
Preparation Host Flows: Tap Sequence Analysis
The tap_sequence_analysis was adapted to store the protocol of each
frame. Therefore a new variable was introduced. In case of an ICMP or
ICMPv6 packet, the ICMP message type and code is retrieved. The adapted
ICMP and ICMPv6 dissector stores both values in packet info (see [1]).
In case of ICMP and ICMPv6 packets, the source and destination port is
not set or 0, respectively. Compared to that, the NetFlow service export
protocol [2] codes the ICMP message type and code into the port numbers.
The source port is zero while the destination is defined as: destination
port = ICMP type * 256 + ICMP code. This definition was implemented for
the ICMP and ICMPv6 packets.
References
[1] https://code.wireshark.org/review/10097
[2] http://www.ietf.org/rfc/rfc3954.txt
Change-Id: I07518e360975682a3f45e80cb24f82f58cfb15f0
Reviewed-on: https://code.wireshark.org/review/10098
Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from d05b6f9 Bluetooth: ATT: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
adds 89a8ad6 Preparation Host Flows: Tap Sequence Analysis
Summary of changes:
ui/tap-sequence-analysis.c | 26 ++++++++++++++++++++++++++
ui/tap-sequence-analysis.h | 1 +
2 files changed, 27 insertions(+)
