Wireshark-commits: [Wireshark-commits] master fa40025: Recompile dfilter for all tap listeners when
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 19 Aug 2015 08:55:26 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fa40025a7e2e9ddc5590515989074df1662dcc82
Submitter: Stig Bjørlykke (stig@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

fa40025 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Recompile dfilter for all tap listeners when fields changed
    
    When fields have changed the compiled display filter may be invalid
    or need a recompile to be valid.
    
    Filters which are not valid after a recompile is set to a filter
    matching no packets (frame.number == 0) to indicate that this does
    no longer match anything.  We should probably have a better filter
    matching no packet for this purpose.
    
    Change-Id: Id27efa9f46e77e20df50d7366f26d5cada186f93
    Reviewed-on: https://code.wireshark.org/review/10123
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    

Actions performed:

    from  b755a66   Use MAC address documentation range in filter examples
    adds  fa40025   Recompile dfilter for all tap listeners when fields changed


Summary of changes:
 epan/tap.c                  |   30 ++++++++++++++++++++++++++++++
 epan/tap.h                  |    3 +++
 ui/qt/main_window_slots.cpp |    1 +
 3 files changed, 34 insertions(+)