URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4048ca0a27b7ed693b91103ed6912a4a1abfa3db
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
4048ca0 by Martin Kaiser (wireshark@xxxxxxxxx):
rewrite the H1 dissector
* use the offset variable to keep track of where we are,
remove the position variable
(previously, offset remained 0 all the time...)
* use proto_tree_add_item()
* highlight the correct bytes for each field
* define a block type and block length instead of
naming these fields differently for each block
* indent by 4 spaces
Change-Id: Ie0995e5fe6364605fd30020f171e51458844fa59
Reviewed-on: https://code.wireshark.org/review/10080
Petri-Dish: Martin Kaiser <wireshark@xxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
Reviewed-by: Hadriel Kaplan <hadrielk@xxxxxxxxx>
Actions performed:
from acc0c14 Eliminate proto_tree_add_text from XMPP dissectors.
adds 4048ca0 rewrite the H1 dissector
Summary of changes:
epan/dissectors/packet-h1.c | 364 ++++++++++++++++++++-----------------------
1 file changed, 166 insertions(+), 198 deletions(-)
