Wireshark-commits: [Wireshark-commits] master 8282540: Eliminate proto_tree_add_text from GSM disse
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 15 Aug 2015 06:49:46 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=828254042a703fd8452f87873c01c3260a67d554
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8282540 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Eliminate proto_tree_add_text from GSM dissectors.
    
    Change-Id: I36a3d15a4fa86847a83d1dbea40111d36d7cfd61
    Reviewed-on: https://code.wireshark.org/review/10036
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  8368f3b   Update the previously-added comment.
    adds  8282540   Eliminate proto_tree_add_text from GSM dissectors.


Summary of changes:
 epan/dissectors/packet-gsm_a_rr.c   |  129 ++++++++++++++++++++++-------------
 epan/dissectors/packet-gsm_cbch.c   |   73 ++++++++++++++------
 epan/dissectors/packet-gsm_rlcmac.c |   45 ++++++------
 3 files changed, 154 insertions(+), 93 deletions(-)