Wireshark-commits: [Wireshark-commits] master 463caf8: Discuss alternatives to polling all the rece
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 15 Aug 2015 01:49:56 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=463caf8c5593f9b635ab2a46e25655a64d0f8591
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

463caf8 by Guy Harris (guy@xxxxxxxxxxxx):

    Discuss alternatives to polling all the recent files every 2 seconds.
    
    Somebody asked about repeated SMB traffic when running the Qt Wireshark:
    
    https://ask.wireshark.org/questions/45036/permanent-smb2-traffic-with-1997
    
    and that's due to said polling.  On the main desktop platforms (Windows,
    OS X, Linux) we can use QFileSystemWatcher plus, on Windows and OS X,
    some additional stuff to check for unmounts (and get FreeBSD as a
    freebie, as it works the same as OS X), and avoid timeout-based polling.
    
    Change-Id: I3a1d0110fedcdb442ed09c16dab4bf0cb06ca331
    Reviewed-on: https://code.wireshark.org/review/10038
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  6137197   Fix for the current wireshark.desktop.
    adds  463caf8   Discuss alternatives to polling all the recent files every 2 seconds.


Summary of changes:
 ui/qt/wireshark_application.cpp |   62 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 62 insertions(+)