Wireshark-commits: [Wireshark-commits] master 5c80f08: Add DCE-RPC and ONC-RPC service response tim
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 12 Aug 2015 20:17:41 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5c80f08648ed14ecc03c20d8c52f25d71b03dd26
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5c80f08 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Add DCE-RPC and ONC-RPC service response time dialogs.
    
    Add RpcServiceResponseTimeDialog, which handles DCE-RPC and ONC-RPC
    service response time statistics. Try to make it as lightweight as
    possible, since we might want to pull this into the RPC dissectors
    similar to the other SRT statistics.
    
    Allow program names on the command line in place of numbers or UUIDs. Make
    matches case-insensitive. E.g. the following are equivalent:
    
        -z rpc,srt,100003,3
        -z rpc,srt,nfs,3
        -z rpc,srt,NFS,3
    
    as are the following:
    
        -z dcerpc,srt,f5cc5a18-4264-101a-8c59-08002b2f8426,56
        -z dcerpc,srt,nspi,56
        -z dcerpc,srt,NSPI,56
    
    Change-Id: Ie451c64bf6fbc776f27d81e3bc248435c5cbc9e4
    Reviewed-on: https://code.wireshark.org/review/9981
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  412f5b3   Expert information dialog performance improvements.
    adds  5c80f08   Add DCE-RPC and ONC-RPC service response time dialogs.


Summary of changes:
 doc/wireshark.pod.template                 |   18 +-
 epan/dissectors/packet-dcerpc.h            |    3 +
 epan/dissectors/packet-rpc.h               |   14 +-
 epan/guid-utils.h                          |    2 +-
 epan/stat_tap_ui.h                         |    2 +-
 ui/gtk/dcerpc_stat.c                       |   21 +-
 ui/qt/CMakeLists.txt                       |    2 +
 ui/qt/Makefile.common                      |    4 +-
 ui/qt/Wireshark.pro                        |    2 +
 ui/qt/main_window_slots.cpp                |    1 +
 ui/qt/qt_ui_utils.cpp                      |    6 +
 ui/qt/qt_ui_utils.h                        |   12 +-
 ui/qt/rpc_service_response_time_dialog.cpp |  436 ++++++++++++++++++++++++++++
 ui/qt/rpc_service_response_time_dialog.h   |   96 ++++++
 ui/qt/service_response_time_dialog.cpp     |   16 +-
 ui/qt/service_response_time_dialog.h       |    6 +-
 ui/qt/tap_parameter_dialog.cpp             |   19 +-
 ui/qt/tap_parameter_dialog.h               |    7 +
 ui/qt/tap_parameter_dialog.ui              |   10 +-
 19 files changed, 633 insertions(+), 44 deletions(-)
 create mode 100644 ui/qt/rpc_service_response_time_dialog.cpp
 create mode 100644 ui/qt/rpc_service_response_time_dialog.h