Wireshark-commits: [Wireshark-commits] master bfdc2cb: Eliminate proto_tree_add_text from some diss
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 12 Aug 2015 08:14:19 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bfdc2cb7a39d12cecfe07f3e2897acbe81032b7e
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

bfdc2cb by Michael Mann (mmann78@xxxxxxxxxxxx):

    Eliminate proto_tree_add_text from some dissectors.
    
    Change-Id: I7a7778802c442b254626a7676cb74ca2855fa65e
    Reviewed-on: https://code.wireshark.org/review/9977
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  50b51a6   Some further questions, asked in comments.
    adds  bfdc2cb   Eliminate proto_tree_add_text from some dissectors.


Summary of changes:
 epan/dissectors/packet-dcerpc-spoolss.c |  246 +++++++++++++++++--------------
 epan/dissectors/packet-mip6.c           |  120 +++++++++------
 epan/dissectors/packet-mpls-echo.c      |   82 ++++++-----
 epan/dissectors/packet-rtcp.c           |  165 ++++++++++++---------
 epan/dissectors/packet-tipc.c           |  118 ++++++++++++---
 5 files changed, 452 insertions(+), 279 deletions(-)