Wireshark-commits: [Wireshark-commits] master-1.12 39e6153: Don't try to decrypt the payload if it
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 10 Aug 2015 07:51:05 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=39e61530847678939a4d248e3d01e4b366cb7539
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

39e6153 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't try to decrypt the payload if it was cut short by the snapshot length.
    
    It's not clear that the decryption code can handle an incomplete
    payload.  If it can, please fix this (bear in mind that you won't have
    all the MIC, and may not have *any* of the MIC, so...).
    
    Bug: 11389
    Change-Id: If97fee05c03d59580d790cb79da6455b615596c1
    Reviewed-on: https://code.wireshark.org/review/9957
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  76d50a7   Use the reported length where appropriate.
    adds  39e6153   Don't try to decrypt the payload if it was cut short by the snapshot length.


Summary of changes:
 epan/dissectors/packet-zbee-security.c |   46 ++++++++++++++++++++++----------
 1 file changed, 32 insertions(+), 14 deletions(-)