Wireshark-commits: [Wireshark-commits] master c462f1b: Eliminate proto_tree_add_text from packet-wb
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 10 Aug 2015 04:47:26 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c462f1b54ed4459c0c93dabbf5fe30f224e796a6
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c462f1b by Michael Mann (mmann78@xxxxxxxxxxxx):

    Eliminate proto_tree_add_text from packet-wbxml.c
    
    While I was at it, some (mostly) duplicate functionality allowed rearranging of functions to eliminate most forward declarations.
    
    Change-Id: I2d7027d336c391d81dfe81c7a1ebf0d56c0826b2
    Reviewed-on: https://code.wireshark.org/review/9951
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  6d8b4af   Cleanup variable name in dissect_frag6()
    adds  c462f1b   Eliminate proto_tree_add_text from packet-wbxml.c


Summary of changes:
 epan/dissectors/packet-wbxml.c | 2048 +++++++++++++++-------------------------
 1 file changed, 784 insertions(+), 1264 deletions(-)